This explains SQL stored procedures and their advantages.

  • deegeese@sopuli.xyz
    link
    fedilink
    English
    arrow-up
    13
    ·
    1 year ago

    A stored procedure is like making an API for your DB schema. It made a fair bit of sense before microservices existed.

    Nowadays you really shouldn’t be exposing the DB schema in the first place.

  • wvenable@lemmy.ca
    link
    fedilink
    English
    arrow-up
    13
    arrow-down
    1
    ·
    1 year ago

    This my hot take: Do not use stored procedures with applications. Keep your data separate from your code.

    • AlecSadler@lemmy.world
      link
      fedilink
      English
      arrow-up
      7
      arrow-down
      1
      ·
      1 year ago

      Could you explain more? Almost everywhere I’ve worked from Fortune 250 on down has used stored procedures with applications and it seems extremely clean and performance-oriented.

      If anything, it separates code from the data more as far as I can tell, so maybe I’m missing something?

      Also, if something is somewhat data driven and there’s a bug, you simply alter a procedure versus doing a build and deploy of the entire application.

      • wvenable@lemmy.ca
        link
        fedilink
        English
        arrow-up
        10
        ·
        edit-2
        1 year ago

        If anything, it separates code from the data more as far as I can tell, so maybe I’m missing something?

        Stored procedures are code – so you’re putting code in the database. How do you test that code? How do you source control that code? How do you roll back that code to the previous version or compare it to a previous version? How to know the history of that code? If that procedure is designed to work in together with application changes, how to test and deploy those together? This is all not impossible but it’s certainly more difficult and creates more potential failure points.

        Also, if something is somewhat data driven and there’s a bug, you simply alter a procedure versus doing a build and deploy of the entire application.

        That’s the problem. You write like that like it’s an advantage but you’re literally editing code live in production.

        The performance advantages of stored procedures are unsupported. Most database engines do not treat stored procedures any differently than regular queries. And it’s not that stored procedures aren’t optimized, it’s that queries are equally optimized.

        Fortune 250 on down has used stored procedures with applications and it seems extremely clean and performance-oriented.

        A lot of these companies also still use COBOL on mainframes (something I’ve actually worked on and don’t recommend either). Stored procedures made a lot more sense historically when SQL might actually have more expressive power than your programming language and when database interfaces were much complicated and non-standard.

    • Distributed@lemmy.ml
      link
      fedilink
      English
      arrow-up
      4
      ·
      edit-2
      1 year ago

      Whats your preferred method of accessing sql, in that case? Most companies I’ve worked for use sprocs. ORM?

  • CodeBlooded@programming.dev
    link
    fedilink
    English
    arrow-up
    10
    ·
    edit-2
    1 year ago

    In my experience, 9/10 times a stored procedure is code that should just be SQL executed from your application (as in, your application sends the query text to the db, rather than that text being stored in the database and executed via calling a stored procedure).

    If it’s necessary for performance, sure, go for it. Satisfy your requirements. If it’s not necessary for performance, ask yourself why it needs to be a stored procedure deployed to the database.

    • Matthew@programming.dev
      link
      fedilink
      English
      arrow-up
      4
      ·
      1 year ago

      My boss is a DB dev and requires that all our database transactions go through stored procedures. Oh, and those stored procedures contain all our business logic.

      • CodeBlooded@programming.dev
        link
        fedilink
        English
        arrow-up
        7
        ·
        edit-2
        1 year ago

        My condolences. This is the stuff Robert C. Martin talks about in his book “Clean Architecture”; database vendors locking you into their tech.

        Your boss isn’t just a developer, he’s a *db developer *. From his perspective, the database is a god rather than a means to store information.

        I should add onto my original post that the queries should strive to be as database agnostic as possible. This alleviates a lot of pain when the company decides to move from one DBMS to another.

        Is it safe to assume your stored procedures have lots of DBMS specific functions and syntax sprinkled among the code?

    • ramplay@lemmy.ca
      link
      fedilink
      English
      arrow-up
      3
      ·
      1 year ago

      My companies whole of BI is operated through Stored Procs… Its a tad insane

        • ramplay@lemmy.ca
          link
          fedilink
          English
          arrow-up
          1
          ·
          edit-2
          1 year ago

          It’s in git. In our current but on its last legs env we had a inhouse built tool that would compare a release branch with master and build a series files we’d throw at the DBA to run updating procs, tables, views, etc. Had procs built to preserve data when ddl changed and what not. Very painful. This was on Netezza.-

          Now we are moving to Azure Synapse… And we are using Azure DevOps instead of Bitbucket and it works but its jank. Our git repo is now actually tied to the DB through the use of release pipelines. PRs on master will get released automatically… That said most recent update from msft and now it takes 7hrs just for the deployment plan to build.

          Its not great… My company is addicted to stored procs. I hear there is some projects looking into databricks, azure data factory, sparks, etc… For now my life is pain and complaints, just trying to get people to learn to love git. BI here before I joined unfortunately not IT minded.

          Edit: didn’t even touch on testing… And frankly half the devs seem like they don’t/don’t know how to even do impact analysis… If you change a column, at minimum search the code base for impacts… Don’t just deploy and blow up our prod cause you’re mismatching sizes